Schrijf leesbare code

SQL toepassen op problemen uit de praktijk

Dmitriy (Dima) Gorenshteyn

Lead Data Scientist, Memorial Sloan Kettering Cancer Center

Schrijf SQL-commando's met hoofdletters

Origineel

select 
  title as film_title, 
  description as film_description
from rental as r
join inventory as i
  on r.inventory_id = i.inventory_id
join film as f
  on i.film_id = f.film_id
where f.length > 90
  and f.replacement_cost > 20;

Verbeterd

SELECT 
  title AS film_title, 
  description AS film_description
FROM rental AS r
JOIN inventory AS i
  ON r.inventory_id = i.inventory_id
JOIN film AS f
  ON i.film_id = f.film_id
WHERE f.length > 90
  AND f.replacement_cost > 20;

Gebruik nieuwe regels en inspringing

Origineel

SELECT title, description
FROM rental AS r
JOIN inventory AS i
ON r.inventory_id = i.inventory_id
JOIN film AS f ON i.film_id = f.film_id
WHERE f.length > 90 AND f.replacement_cost > 20;

Verbeterd

SELECT title, 
       description 
FROM rental AS r
JOIN inventory AS i
  ON r.inventory_id = i.inventory_id
JOIN film AS f
  ON i.film_id = f.film_id
WHERE f.length > 90
  AND f.replacement_cost > 20;

Gebruik snake_case

Origineel

SELECT 
  title expensivelongtitle, 
  description expensivelongdescription
FROM rental AS r
...

Verbeterd

SELECT 
  title expensive_long_title, 
  description expensive_long_description
FROM rental AS r
...

Gebruik IN in plaats van veel OR's

Origineel

SELECT 
    address_id,  
    district 
FROM address
WHERE district = 'Texas'
  OR district = 'Bihar'
  OR district = 'Chiba'
  OR district = 'Chiayi'
  OR district = 'Gois';

Verbeterd

SELECT 
    address_id,  
    district 
FROM address
WHERE district IN ('Texas', 'Bihar', 'Chiba', 
                   'Chiayi', 'Gois');

Gebruik BETWEEN waar mogelijk

Origineel

SELECT 
  title, 
  description
FROM film
WHERE replacement_cost > 15
  AND replacement_cost < 25;

Verbeterd

SELECT 
  title, 
  description
FROM film
WHERE replacement_cost BETWEEN 15 AND 25;

Laten we oefenen!

SQL toepassen op problemen uit de praktijk