Reviewing pull requests

Giới thiệu về các khái niệm GitHub

Jasmin Ludolf

Content Developer, DataCamp

How to request a review of a PR

View of pull request with the reviewer section visible

Giới thiệu về các khái niệm GitHub

Assign vs. Review

Assignee

  • Approves the PR

Reviewer

  • Looks at the changes before the PR is merged
Giới thiệu về các khái niệm GitHub

How to request a review of a PR

View with a reviewer requested

Giới thiệu về các khái niệm GitHub

How to review a PR

Owner view of the PR tab

Giới thiệu về các khái niệm GitHub

How to review a PR

Owner view of the PR tab highlighting the PR we are clicking on

Giới thiệu về các khái niệm GitHub

How to review a PR

Owner view of the files changed tab in a PR

Giới thiệu về các khái niệm GitHub

Reviewing a PR

Owner view of the files changed tab in a PR highlighting the red highlight

Giới thiệu về các khái niệm GitHub

Reviewing a PR

Owner view of the files changed tab in a PR highlighting the green highlight

Giới thiệu về các khái niệm GitHub

Reviewing a PR

Owner view of the files changed tab in a PR with the review changes dropdown visible

Giới thiệu về các khái niệm GitHub

Adding comments to a PR

Owner view of the files changed tab in a PR with the blue cross icon visible

Giới thiệu về các khái niệm GitHub

Adding comments to a PR

Owner view of the files changed tab in a PR with comment box for one line

Giới thiệu về các khái niệm GitHub

Adding comments to a PR

Owner view of the files changed tab in a PR with comment box for multiple lines

Giới thiệu về các khái niệm GitHub

Responding to a PR

Close up view of the options to respond to a PR with a circle around the request changes option.

Giới thiệu về các khái niệm GitHub

Comment vs. Request changes

Close up view of the options to respond to a PR with a circle around the comment option.

Comment

  • Feedback
  • Suggestions
  • No requirement to change the project
Giới thiệu về các khái niệm GitHub

Comment vs. Request changes

Request Changes

  • Feedback that needs to be incorporated

Close up view of the options to respond to a PR with a circle around the request changes option.

Giới thiệu về các khái niệm GitHub

Requesting changes

Contributor view to make the requested changes.

Giới thiệu về các khái niệm GitHub

Requesting changes

Contributor view to re-request review.

Giới thiệu về các khái niệm GitHub

Approving a PR

Owner view of a PR with the Approve option highlighted

Giới thiệu về các khái niệm GitHub

Merging a PR

Owner view of an approved PR with the merge button highlighted

Giới thiệu về các khái niệm GitHub

Merging a PR

Owner view of an approved PR with the confirm merge button highlighted

Giới thiệu về các khái niệm GitHub

Deleting a branch after a PR

Owner view of a merged PR with the delete branch button highlighted

Giới thiệu về các khái niệm GitHub

Restoring a deleted branch

Owner view of a merged PR with the restore branch button highlighted

Giới thiệu về các khái niệm GitHub

Restoring from a closed PR

View of the Pull requests tab

Giới thiệu về các khái niệm GitHub

Restoring from a closed PR

View of the pull requests tab highlighting the prs on the repo

Giới thiệu về các khái niệm GitHub

Restoring from a closed PR

View of the closed PRs

Giới thiệu về các khái niệm GitHub

Restoring from a closed PR

View of the restore button in a closed PR

Giới thiệu về các khái niệm GitHub

Let's practice!

Giới thiệu về các khái niệm GitHub

Preparing Video For Download...